fix(NcActions): NcActionCheckbox and NcActionRadio icon alignment #5958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: greta <[email protected]>
ShGKme
changed the title
susnux
approved these changes
Aug 14, 2024
|
/backport to next |
ShGKme
approved these changes
Aug 14, 2024
| @@ -206,8 +206,7 @@ export default { | |||
|
|
|||
| &::before { | |||
| margin-block: 0 !important; | |||
| // 16px is the width of the checkbox including the border | |||
| margin-inline: calc((var(--default-clickable-area) - 16px) / 2) !important; | |||
| margin-inline: calc((var(--default-clickable-area) - 14px) / 2) !important; | |||
There was a problem hiding this comment.
Probably, we should either add CSS variable for it, or change layout here to not use this number to avoid magic numbers.
P.S. On all supported versions on server it is 14px, not 16px
https://github.com/nextcloud/server/blob/stable28/core/css/inputs.scss#L414
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
🏚️ Before | 🏡 After
|
🚧 Tasks
🏁 Checklist
nextrequested with a Vue 3 upgrade