-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(useHotKey): add composable for keyboard shortcuts #5899
Conversation
ee0c7aa
to
acbcb4a
Compare
acbcb4a
to
c6522ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about making it less a vueuse
function wrapper, but more a specifically "hot keys" utility so that:
- explicitly mark it as an utility for hotkeys
- do not rely on vueuse and change implementation if needed
- do not promise to support interface we actually don't need in hot keys
(discussed in the office)
Very cool docs! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Works fine, great examples in docs
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
6060239
to
95dfaaa
Compare
/backport to next |
☑️ Resolves
Moved from nextcloud/spreed#12698
Add a new
useHotKey
composable with respect Nextcloud Accessibility settingAvailable modifiers:
🖼️ Screenshots
🚧 Tasks
interactive
elements🏁 Checklist
next
requested with a Vue 3 upgrade