-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NcPasswordField): add as-text prop to remove autocomplete #5896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme
added
3. to review
Waiting for reviews
feature: input-field
Covering the InputField, TextField, ...
labels
Aug 2, 2024
ShGKme
changed the title
feat(NcPasswordField): allow to show as input[type=text] without auto…
feat(NcPasswordField): add as-text prop to remove autocomplete
Aug 2, 2024
/backport to next |
Antreesy
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, looks good by the code changes and caniuse info
susnux
approved these changes
Aug 3, 2024
Yeah, I didn't find a better solution :( |
2 tasks
Merged
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
enhancement
New feature or request
feature: input-field
Covering the InputField, TextField, ...
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
autocomplete="off"
, browsers ignore it.Proposal: add a new
as-text
prop that forces usingtype="text"
and emulates password field view.Note:
-webkit-text-security
is not a standard feature, but well supported.🖼️ Screenshots
🚧 Tasks
as-text
prop to force text type and prevent autocomplete and🏁 Checklist
next
requested with a Vue 3 upgrade