fix(NcInputField): Make focus visible on trailing button look better #5823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
susnux
requested review from
JuliaKirschenheuter,
Pytal,
marcoambrosini and
Antreesy
|
/backport to next |
marcoambrosini
approved these changes
Jul 18, 2024
Antreesy
approved these changes
Jul 18, 2024
ShGKme
approved these changes
Jul 18, 2024
Signed-off-by: Ferdinand Thiessen <[email protected]>
… field Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/ui-trailing-button
branch
from
089f61c to
ca38469
Compare
2 tasks
This was referenced Aug 14, 2024
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Currently the focus visible outline intersects with the input border, so lets shrink the button a bit to fix.
🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade