fix(NcAppNavigationCaption): properly align with NcAppNavigationItem #5804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nItem Signed-off-by: Grigory V <[email protected]>
ChristophWurst
approved these changes
Jul 15, 2024
| @@ -240,7 +240,7 @@ export default { | |||
| box-shadow: none !important; | |||
| flex-shrink: 0; | |||
| // padding to align the name with the icon of app navigation items | |||
There was a problem hiding this comment.
this comment confirms the alignment needed adjustment ;-)
GVodyanov
requested review from
ChristophWurst and
marcoambrosini
and removed request for
marcoambrosini
ChristophWurst
approved these changes
Jul 15, 2024
marcoambrosini
approved these changes
Jul 15, 2024
CI job restarted. This seems unrelated. |
|
I changed one CSS character and CI still fails 😭 |
ChristophWurst
added
4. to release
|
@ShGKme could you help finding out if force merge is ok here? |
Just restart CI until it's green (from 1 to 5 times) |
ShGKme
added
bug
ShGKme
changed the title
|
Restarted and green now |
|
/backport to next |
|
Don't forget the checklist and bug/enhancement tags for changelog gen 👀 |
ShGKme
changed the title
This was referenced Aug 14, 2024
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make NcAppNavigationCaption properly align with NcAppNavigationItem
☑️ Resolves
🖼️ Screenshots