Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] feat: migrate NcCollectionList component from nextcloud-vue-collections #5770

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jul 3, 2024

@backportbot backportbot bot requested review from DorraJaouad, susnux and Antreesy July 3, 2024 20:45
@backportbot backportbot bot added enhancement New feature or request 3. to review Waiting for reviews component Component discussion and/or suggestion labels Jul 3, 2024
Antreesy added 2 commits July 4, 2024 10:33
…d/vue

Signed-off-by: Maksim Sukharev <[email protected]>

(cherry picked from commit 0637422)
Signed-off-by: Maksim Sukharev <[email protected]>
- migrate service from Class to simple functions
- migrate store to composable
- make NcCollectionListItem a visual component
- update avatar styles
- use RouterLink for relative paths in the same app
- update message.pot translations
- add docs

Signed-off-by: Maksim Sukharev <[email protected]>

(cherry picked from commit 94177fe)
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the backport/5757/next branch from 8666db6 to a486502 Compare July 4, 2024 08:46
@Antreesy Antreesy force-pushed the backport/5757/next branch from a486502 to 3c1412f Compare July 4, 2024 08:52
@Antreesy Antreesy marked this pull request as ready for review July 4, 2024 08:54
@susnux susnux merged commit a7a1c02 into next Jul 4, 2024
19 checks passed
@susnux susnux deleted the backport/5757/next branch July 4, 2024 16:06
@susnux
Copy link
Contributor

susnux commented Jul 4, 2024

Time to deprecate vue-collections?

@Antreesy
Copy link
Contributor

Antreesy commented Jul 4, 2024

Time to deprecate vue-collections?

Yes, already tested with 8.14.0 release =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews component Component discussion and/or suggestion enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants