-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: re-export NcEllipsisedOption
and NcInputField
in root export
#5666
Conversation
/backport to next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me
nit: the patch changes the exports of the library so semantically it's a feat or fix 🤓 |
NcEllipsisedOption
and NcInputField
in root export
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
c167fcb
to
2fe66e8
Compare
Renamed to |
The backport to # Switch to the target branch and update it
git checkout next
git pull origin next
# Create the new backport branch
git checkout -b backport/5666/next
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick eebde479 2fe66e8d
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5666/next Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Both components were not only documented and available in a direct import
@nextcloud/vue/dist/Components/*
but also used in apps already.🏁 Checklist
next
requested with a Vue 3 upgrade