Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NcEllipsisedOption): add docs #5663

Merged
merged 1 commit into from
Jun 4, 2024
Merged

chore(NcEllipsisedOption): add docs #5663

merged 1 commit into from
Jun 4, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jun 4, 2024 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

@ShGKme ShGKme added feature: documentation Related to the documentation feature: select Related to the NcSelect* components feature: ellipsised-option labels Jun 4, 2024
@ShGKme ShGKme requested review from susnux and Pytal June 4, 2024 13:44
@ShGKme ShGKme self-assigned this Jun 4, 2024
@ShGKme
Copy link
Contributor Author

ShGKme commented Jun 4, 2024

/backport to next

susnux
susnux reviewed Jun 4, 2024
View reviewed changes
src/components/NcEllipsisedOption/NcEllipsisedOption.vue Outdated
```vue
<template>
<div>
<h5>Plain text</h5>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be h4 no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks too huge to me 👀

But can replace it with h4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or with separated examples

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do it

Copy link
Contributor Author

@ShGKme ShGKme Jun 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, screenshot updated

@ShGKme
chore(NcEllipsisedOption): add docs
e3699d5 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme ShGKme force-pushed the docs/NcEllipsisedOption branch from 3ee528e to e3699d5 Compare June 4, 2024 14:16
@ShGKme ShGKme mentioned this pull request Jun 4, 2024
Open
@ShGKme ShGKme merged commit 8601351 into master Jun 4, 2024
17 checks passed
@ShGKme ShGKme deleted the docs/NcEllipsisedOption branch June 4, 2024 19:11
@backportbot backportbot bot mentioned this pull request Jun 4, 2024
Merged
@susnux susnux mentioned this pull request Jun 20, 2024
Merged
1 task
@susnux susnux mentioned this pull request Jul 3, 2024
Closed
4 tasks
This was referenced Aug 9, 2024
Open
Open
This was referenced Aug 19, 2024
Open
Open
This was referenced Sep 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@susnux susnux susnux approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

Assignees

@ShGKme ShGKme

Labels
feature: documentation Related to the documentation feature: ellipsised-option feature: select Related to the NcSelect* components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShGKme @susnux @Pytal