fix(NcIconSvgWrapper): Fix icon size variable being undefined #5597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
ShGKme,
Antreesy,
max-nextcloud and
DorraJaouad
and removed request for
DorraJaouad
Use CSS variable with `style` binding instead, as the `v-bind` generated an undefined CSS variable. (Yet for the next branch, Vue 3, it seems to work). Signed-off-by: Ferdinand Thiessen <[email protected]>
DorraJaouad
approved these changes
May 16, 2024
ShGKme
approved these changes
May 16, 2024
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Use CSS variable with
stylebinding instead, as thev-bindgenerated an undefined CSS variable. (Yet for the next branch, Vue 3, it seems to work).🖼️ Screenshots
🏁 Checklist
Backport tonextrequested with a Vue 3 upgrade