Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NcAppNavigationCaption): Allow to set heading level #5567

Merged
merged 1 commit into from
May 9, 2024
Merged

feat(NcAppNavigationCaption): Allow to set heading level #5567

merged 1 commit into from
May 9, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented May 8, 2024 •
edited
Loading

☑️ Resolves

Allow to adjust the heading level if needed.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component labels May 8, 2024
@susnux susnux requested review from Pytal, ShGKme and Antreesy May 8, 2024 20:27
Antreesy
Antreesy approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Antreesy

This comment was marked as duplicate.

Sign in to view

@susnux
Copy link
Contributor Author

susnux commented May 9, 2024

/backport to next

@susnux susnux merged commit a947607 into master May 9, 2024
18 checks passed
@susnux susnux deleted the feat/caption-level branch May 9, 2024 14:08
@backportbot backportbot bot mentioned this pull request May 9, 2024
Merged
@max-nextcloud max-nextcloud mentioned this pull request May 13, 2024
Merged
@susnux susnux mentioned this pull request Jul 3, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@Antreesy Antreesy Antreesy approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request feature: app-navigation Related to the app-navigation component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @Pytal @Antreesy