Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "fix(NcAppNavigation): Wrap app navigation default slot with scrollable container" #5355

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Mar 6, 2024

☑️ Resolves

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

…crollable container"

This reverts commit 19e7f64.

Signed-off-by: Christopher Ng <[email protected]>
@Pytal Pytal added the 3. to review Waiting for reviews label Mar 6, 2024
@Pytal Pytal added this to the 8.9.1 milestone Mar 6, 2024
@Pytal Pytal self-assigned this Mar 6, 2024
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@Pytal Pytal merged commit 7bdee39 into master Mar 6, 2024
18 checks passed
@Pytal Pytal deleted the revert/5347 branch March 6, 2024 14:31
@Pytal Pytal added the bug Something isn't working label Mar 6, 2024
@Pytal Pytal mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants