Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: List team resources in related resources panel #5316

Merged
merged 1 commit into from
Mar 6, 2024
Merged

feat: List team resources in related resources panel #5316

merged 1 commit into from
Mar 6, 2024
+279 −13

Conversation

juliusknorr
Copy link
Contributor

@juliusknorr juliusknorr commented Feb 27, 2024 •
edited by susnux
Loading

☑️ Resolves

🖼️ Screenshots

Screenshot 2024-03-01 at 15 09 11

Previous screen recording

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@juliusknorr juliusknorr force-pushed the feat/teams-related-resources branch from 3eec9af to 8faf8d8 Compare March 1, 2024 11:23
@juliusknorr juliusknorr added enhancement New feature or request 2. developing Work in progress labels Mar 1, 2024
@juliusknorr juliusknorr added this to the 8.9.0 milestone Mar 1, 2024
@juliusknorr juliusknorr force-pushed the feat/teams-related-resources branch 2 times, most recently from 3f4281c to 742fc43 Compare March 1, 2024 14:20
@juliusknorr juliusknorr added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 1, 2024
@juliusknorr juliusknorr marked this pull request as ready for review March 1, 2024 14:21
@juliusknorr juliusknorr force-pushed the feat/teams-related-resources branch from 742fc43 to 146908c Compare March 1, 2024 14:22
GretaD
GretaD approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

mejo-
mejo- requested changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well already, but I have some comments 😊

src/components/NcRelatedResourcesPanel/NcTeamResources.vue Outdated Show resolved Hide resolved
src/components/NcRelatedResourcesPanel/NcTeamResources.vue Show resolved Hide resolved
src/components/NcRelatedResourcesPanel/NcTeamResources.vue Outdated Show resolved Hide resolved
src/components/NcRelatedResourcesPanel/NcTeamResources.vue Outdated Show resolved Hide resolved
src/components/NcRelatedResourcesPanel/NcTeamResources.vue Outdated Show resolved Hide resolved
@juliusknorr juliusknorr force-pushed the feat/teams-related-resources branch from 146908c to 80aa3af Compare March 5, 2024 19:07
@juliusknorr juliusknorr requested review from mejo- and ShGKme March 5, 2024 19:07
@juliusknorr
Copy link
Contributor Author

Thanks @mejo- and @ShGKme ... should all be addressed

@juliusknorr juliusknorr mentioned this pull request Mar 5, 2024
Closed
28 tasks
@juliusknorr juliusknorr merged commit c3bb5c6 into master Mar 6, 2024
19 checks passed
@juliusknorr juliusknorr deleted the feat/teams-related-resources branch March 6, 2024 09:55
@juliusknorr juliusknorr mentioned this pull request Mar 6, 2024
Merged
@ShGKme
Copy link
Contributor

ShGKme commented Mar 8, 2024

/backport to next

@backportbot backportbot bot mentioned this pull request Mar 8, 2024
Merged
@skjnldsv
Copy link
Contributor

skjnldsv commented Jul 3, 2024

@juliushaertl @mejo- is it intended that the component is exported?
The documentation is non-existent :(

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GretaD GretaD GretaD approved these changes

@mejo- mejo- mejo- approved these changes

@susnux susnux Awaiting requested review from susnux

@Pytal Pytal Awaiting requested review from Pytal

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
8.9.0
Development

Successfully merging this pull request may close these issues.

Improve related resource listing for teams
5 participants
@juliusknorr @ShGKme @skjnldsv @mejo- @GretaD