Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcHeaderMenu): button size regression on small viewports fixed #5149

Merged
merged 1 commit into from
Feb 2, 2024
Merged

fix(NcHeaderMenu): button size regression on small viewports fixed #5149

merged 1 commit into from
Feb 2, 2024

Conversation

emoral435
Copy link
Contributor

☑️ For #5129

🖼️ Screenshots

🏚️ Before 🏡 After
image firefox_I6ssjqt0MZ

🚧 Tasks

Regression for the aforementioned PR

  • On small viewports, the button nested inside the wrapper for NcHeaderMenu stayed 50x50 px. This change ensures that the trigger button is the same size as the wrapper component on small viewports, which is 44x50 px. This now keeps the styling on the server consistent and working!

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@emoral435 emoral435 added bug Something isn't working 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Jan 26, 2024
@emoral435 emoral435 added this to the 8.5.1 milestone Jan 26, 2024
@emoral435 emoral435 requested review from susnux, Pytal and ShGKme January 26, 2024 15:53
@emoral435 emoral435 self-assigned this Jan 26, 2024
@emoral435 emoral435 mentioned this pull request Jan 26, 2024
Merged
3 tasks
Pytal
Pytal approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works!

@susnux susnux modified the milestones: 8.5.1, 8.6.0 Jan 26, 2024
@Antreesy Antreesy modified the milestones: 8.6.0, 8.6.1 Jan 30, 2024
@emoral435 emoral435 force-pushed the regression/5129/mobile-styling branch from c577ca5 to aea427c Compare February 1, 2024 14:43
@ShGKme ShGKme modified the milestones: 8.6.1, 8.6.2 Feb 1, 2024
@susnux susnux merged commit 78c7078 into master Feb 2, 2024
18 checks passed
@susnux susnux deleted the regression/5129/mobile-styling branch February 2, 2024 11:55
ShGKme pushed a commit that referenced this pull request Feb 5, 2024
@susnux @ShGKme
Merge pull request #5149 from nextcloud-libraries/regression/5129/mob…
bf69706 
…ile-styling

fix: button size regression on small viewports fixed
@ShGKme ShGKme changed the title fix: button size regression on small viewports fixed fix(NcHeaderMenu): button size regression on small viewports fixed Feb 7, 2024
@ShGKme ShGKme mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme left review comments

@Pytal Pytal Pytal approved these changes

@susnux susnux susnux approved these changes

Assignees

@emoral435 emoral435

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: header-menu
Projects
None yet
Milestone
8.6.2
Development

Successfully merging this pull request may close these issues.
5 participants
@emoral435 @susnux @Pytal @ShGKme @Antreesy