Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix single-select design #4817

Merged
merged 1 commit into from
Nov 14, 2023
Merged

fix single-select design #4817

merged 1 commit into from
Nov 14, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Nov 14, 2023 •
edited
Loading

Fix #4816

Before After
image image

@szaimen
fix single-select design
07d287d 
Signed-off-by: Simon L <[email protected]>

Signed-off-by: Simon L. <[email protected]>
@szaimen szaimen added the 2. developing Work in progress label Nov 14, 2023
@szaimen szaimen added this to the 8.0.2 milestone Nov 14, 2023
@szaimen szaimen added 3. to review Waiting for reviews bug Something isn't working regression Regression of a previous working feature design Design, UX, interface and interaction design and removed 2. developing Work in progress labels Nov 14, 2023
@szaimen szaimen marked this pull request as ready for review November 14, 2023 13:49
@szaimen szaimen merged commit 96e3bc8 into master Nov 14, 2023
15 checks passed
@szaimen szaimen deleted the enh/4816/fix-single-select branch November 14, 2023 13:57
jancborchardt
jancborchardt reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! :)

@susnux susnux mentioned this pull request Nov 14, 2023
Merged
@AndyScherzinger AndyScherzinger modified the milestones: 8.0.2, 8.1.0 Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt left review comments

@GretaD GretaD GretaD approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design regression Regression of a previous working feature
Projects
None yet
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.

[NcSelect] Single select looks like tag select
5 participants
@szaimen @jancborchardt @AndyScherzinger @ChristophWurst @GretaD