Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] feat(NcHeaderMenu): migrate to vue 3 #4732

Merged
merged 1 commit into from
Oct 31, 2023
Merged

[next] feat(NcHeaderMenu): migrate to vue 3 #4732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ module.exports = {
'src/components/NcBreadcrumb*/*.vue',
'src/components/NcContent/*.vue',
'src/components/NcDashboard*/*.vue',
'src/components/NcHeaderMenu*/*.vue',
'src/components/NcRelatedResourcesPanel*/*.vue',
'src/components/NcRich*/**/*.vue',
'src/components/NcUserBubble*/*.vue',
Expand Down
2 changes: 1 addition & 1 deletion src/components/NcHeaderMenu/NcHeaderMenu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ export default {
mounted() {
document.addEventListener('keydown', this.onKeyDown)
},
beforeDestroy() {
beforeUnmount() {
document.removeEventListener('keydown', this.onKeyDown)
},

Expand Down
2 changes: 1 addition & 1 deletion src/components/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export { default as NcDialogButton } from './NcDialogButton/index.js'
export { default as NcEmojiPicker } from './NcEmojiPicker/index.js'
export { default as NcEmptyContent } from './NcEmptyContent/index.js'
export { default as NcGuestContent } from './NcGuestContent/index.js'
// export { default as NcHeaderMenu } from './NcHeaderMenu/index.js'
export { default as NcHeaderMenu } from './NcHeaderMenu/index.js'
export { default as NcHighlight } from './NcHighlight/index.js'
export { default as NcIconSvgWrapper } from './NcIconSvgWrapper/index.js'
// Not exported on purpose as it is only meant as a base component
Expand Down
1 change: 0 additions & 1 deletion styleguide.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ module.exports = async () => {
'src/components/NcUserBubble/NcUserBubbleDiv.vue',

// Not yet adjusted for vue3
'src/components/NcHeaderMenu*/*.vue',
'src/components/NcRelatedResourcesPanel*/*.vue',
'src/components/NcRichContenteditable*/*.vue',
'src/components/NcUserBubble*/*.vue',
Expand Down