Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcActions): Various accessibility improvements #4648

Merged
merged 5 commits into from
Oct 17, 2023
Merged

fix(NcActions): Various accessibility improvements #4648

merged 5 commits into from
Oct 17, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Oct 14, 2023 •
edited
Loading

Summary

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@Pytal Pytal added the 2. developing Work in progress label Oct 14, 2023
@Pytal Pytal added this to the 8.0.0 milestone Oct 14, 2023
@Pytal Pytal self-assigned this Oct 14, 2023
@Pytal Pytal mentioned this pull request Aug 29, 2023
Closed
4 tasks
@Pytal Pytal force-pushed the fix/a11y/actions-menu branch from 4ffa329 to 20694eb Compare October 16, 2023 23:27
@Pytal Pytal marked this pull request as ready for review October 16, 2023 23:31
@Pytal Pytal added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components accessibility Making sure we design for the widest range of people possible, including those who have disabilities and removed 2. developing Work in progress labels Oct 16, 2023
Pytal and others added 5 commits October 17, 2023 12:38
@susnux susnux force-pushed the fix/a11y/actions-menu branch from 02f07b3 to 8d79071 Compare October 17, 2023 10:38
@susnux susnux merged commit 004698b into master Oct 17, 2023
@susnux susnux deleted the fix/a11y/actions-menu branch October 17, 2023 12:00
@Pytal Pytal mentioned this pull request Oct 23, 2023
Merged
@skjnldsv
Copy link
Contributor

https://github.com/nextcloud-libraries/nextcloud-vue/commits/05e18d032499619a0e68be6b95065a0c81953af9 broke the styling!

Long text are not wrapped anymore...
image

@skjnldsv skjnldsv mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: actions Related to the actions components
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @skjnldsv @susnux @raimund-schluessler