fix: Replace sanitize-svg with dompurify #4557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schlüßler <[email protected]>
Signed-off-by: Raimund Schlüßler <[email protected]>
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
fix/noid/svg-ios
branch
from
41433a2 to
2b1d068
Compare
raimund-schluessler
requested review from
Pytal,
skjnldsv,
susnux,
ShGKme and
marcoambrosini
raimund-schluessler
added
bug
susnux
approved these changes
Sep 22, 2023
skjnldsv
approved these changes
Sep 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
NcIconSvgWrapperon iOS Safari. Safari wouldn't render the SVG if it has nowidthandheightset.skjnldsv/sanitize-svgtodompurifycomputedinstead ofbeforeMountand a method. @Pytal Any reason why this was a method? If yes, we can revert the last commit.🖼️ Screenshots
🏁 Checklist
Related to #4312 which introduced the problem, I think.
PS: If you wonder, why the dependency to
skjnldsv/sanitize-svgis still inpackage-lock.json, this is because we depend onnextcloud\[email protected]which has a dependency tonextcloud/[email protected].