Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(vue3): Migrate Nc*Field #4512

Merged
merged 2 commits into from
Sep 18, 2023
Merged

chore(vue3): Migrate Nc*Field #4512

merged 2 commits into from
Sep 18, 2023

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Sep 9, 2023 •
edited
Loading

This migrates the Nc*Field components to vue 3.

@raimund-schluessler raimund-schluessler added 2. developing Work in progress feature: input-field Covering the InputField, TextField, ... vue 3 Related to the vue 3 migration labels Sep 9, 2023
@raimund-schluessler raimund-schluessler added this to the 9.0.0 next Vue 3 milestone Sep 9, 2023
@raimund-schluessler raimund-schluessler force-pushed the feat/2154/input-field branch 2 times, most recently from 579e28a to 28ffefa Compare September 9, 2023 12:06
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 9, 2023
@raimund-schluessler raimund-schluessler marked this pull request as ready for review September 9, 2023 12:13
@raimund-schluessler raimund-schluessler changed the title fix(vue3): Migrate Nc*Field chore(vue3): Migrate Nc*Field Sep 9, 2023
ShGKme
ShGKme approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking requests and works

@raimund-schluessler
fix(vue3): Migrate Nc*Field
ea7bf3e 
Signed-off-by: Raimund Schlüßler <[email protected]>
@raimund-schluessler
Copy link
Contributor Author

Rebased.

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 18, 2023
@skjnldsv skjnldsv merged commit 33ecf70 into next Sep 18, 2023
@skjnldsv skjnldsv deleted the feat/2154/input-field branch September 18, 2023 11:24
@susnux susnux mentioned this pull request Jan 23, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@susnux susnux Awaiting requested review from susnux

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@Pytal Pytal Awaiting requested review from Pytal

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: input-field Covering the InputField, TextField, ... vue 3 Related to the vue 3 migration
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raimund-schluessler @skjnldsv @ShGKme