-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcRichText
) - keep newlines in rendered Markdown
#4461
Conversation
Signed-off-by: Maksim Sukharev <[email protected]>
/backport to stable7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested 👍
Adding label for auto-generated release notes |
Not sure, if this matches the normal (official?) markdown bevahior:
Fair enough: Normal users will not be aware of the 'two spaces at the end of a line' thing. But at least the paragraph renderimg makes sense. |
The span tags are there for a reason? They look weird and unusual. |
Thought the same, but it's a result of current parsing process. They probably could be removed, but with some deep changes I wouldn't like to touch for a moment |
☑️ Resolves
Enter
,Shift+Enter
), because rendered<span/>
element doesn't contain symbols, so it'sheight === 0
\n\n
in a row) - we paste no-break space (unicode\u00A0
) between to fill the linestrikethroughwithinline code
, as we don't support it yet🖼️ Screenshots
🏚️ Before
Screencast.from.24.08.2023.14.27.11.webm
🏡 After
Screencast.from.24.08.2023.14.26.17.webm
🚧 Tasks
🏁 Checklist