Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NcDialog): New component (moved from @nextcloud/dialogs) #4415

Closed
wants to merge 3 commits into from
Closed

feat(NcDialog): New component (moved from @nextcloud/dialogs) #4415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f3e7ca
feat(NcDialog): Add new NcDialog and NcDialogButton component for gen…
susnux Aug 12, 2023
9bef793
fix(lint): Fix issues with eslint caused by using Typescript in Vue
susnux Aug 12, 2023
2ad1bf7
feat(NcAppSettingsDialog): Migrate to use NcDialog as base component
susnux Aug 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
/**
* @type {import('eslint').ESLint.ConfigData}
*/
module.exports = {
globals: {
EMOJIS: true,
Expand All @@ -9,11 +12,21 @@ module.exports = {
appVersion: true,
},
extends: [
'@nextcloud',
'@nextcloud/eslint-config/typescript',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this config is for .ts files only. We need to update @nextcloud/eslint-config to support Vue + TS with SFC Setup.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, npm run lint doesn't check TS files.

],
plugins: [
'cypress',
],
overrides: [
{
files: ['**/*.vue', '**/*.ts'],
rules: {
// Note: you must disable the base rule as it can report incorrect errors
'func-call-spacing': 'off',
'@typescript-eslint/func-call-spacing': 'error',
},
},
],
parserOptions: {
babelOptions: {
plugins: [
Expand Down
12 changes: 12 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@
"unist-util-visit": "^5.0.0",
"vue": "^2.7.14",
"vue-color": "^2.8.1",
"vue-frag": "^1.4.3",
"vue-material-design-icons": "^5.1.2",
"vue2-datepicker": "^3.11.0"
},
Expand Down
Loading