Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable7] fix(NcSelect): Action input usage #4072

Merged
merged 1 commit into from
May 10, 2023
Merged

[stable7] fix(NcSelect): Action input usage #4072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/NcActionInput/NcActionInput.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ For the multiselect component, all events will be passed through. Please see the
:placeholder="text"
:disabled="disabled"
:append-to-body="false"
:class="{ focusable: isFocusable }"
:input-class="{ focusable: isFocusable }"
class="action-input__multi"
v-bind="$attrs"
v-on="$listeners" />
Expand Down
16 changes: 16 additions & 0 deletions src/components/NcSelect/NcSelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,6 +483,11 @@ export default {
v-bind="propsToForward"
v-on="$listeners"
@search="searchString => search = searchString">
<template #search="{ attributes, events }">
<input :class="['vs__search', inputClass]"
v-bind="attributes"
v-on="events">
</template>
<template #open-indicator="{ attributes }">
<ChevronDown v-bind="attributes"
fill-color="var(--vs-controls-color)"
Expand Down Expand Up @@ -655,6 +660,16 @@ export default {
default: null,
},

/**
* Class for the `input`
*
* Necessary for use in NcActionInput
*/
inputClass: {
type: [String, Object],
default: null,
},

/**
* Input element id
*
Expand Down Expand Up @@ -887,6 +902,7 @@ export default {
propsToForward() {
const {
// Props handled by this component
inputClass,
noWrap,
placement,
userSelect,
Expand Down