Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid showing the reference list if no results were found #4036

Merged
merged 1 commit into from
May 4, 2023

Conversation

juliusknorr
Copy link
Contributor

@juliusknorr juliusknorr commented May 4, 2023

Fixes nextcloud/text#3824

When there is no result for the references we should hide the container and also not fail early on trying to access an undefined object.

Copy link
Contributor

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nickvergessen nickvergessen enabled auto-merge May 4, 2023 17:52
@nickvergessen nickvergessen merged commit a72342c into master May 4, 2023
@nickvergessen nickvergessen deleted the bugfix/reference-list-no-result branch May 4, 2023 18:03
@ShGKme ShGKme added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent loading spinner for link preview when reference_opengraph is false
4 participants