Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NcRichContentEditable: Emit correct rich content on paste #3837

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 28, 2023

Currently the previous content of the NcRichContentEditable is replaced when pasting behind a newline.
This fixes this by emitting the full content after a paste event.

Screen recording

Before

vokoscreenNG-2023-02-28_18-39-38.mp4

After

vokoscreenNG-2023-02-28_18-36-24.mp4

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: rich-contenteditable Related to the rich-contenteditable components labels Feb 28, 2023
@susnux susnux changed the title Emit correct rich content on paste NcRichContentEditable: Emit correct rich content on paste Feb 28, 2023
@skjnldsv
Copy link
Contributor

skjnldsv commented Mar 1, 2023

Nice catch!!

@raimund-schluessler raimund-schluessler merged commit a56ef0b into master Mar 1, 2023
@raimund-schluessler raimund-schluessler deleted the fix/richcontent-paste branch March 1, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pasting Text Into Description Sometimes Deletes All Existing Text Without Any Way to Undo This
3 participants