Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue 3 #3692

Closed
wants to merge 1 commit into from
Closed

Vue 3 #3692

wants to merge 1 commit into from

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Jan 29, 2023

This PR aims at migrating all components to vue3.

Known issues:

  • Rendering markdown with NcRichText does not work
  • There is no vue3 compatible release of @nextcloud/vue-select yet

Breaking changes:

  • Requires the app to use vue3
  • The exact prop of NcAppNavigationItem, NcBreadcrumb, NcButton and NcListItem components is removed as vue-router 4 does not support it anymore

Compiling the Tasks apps vue3 branch from nextcloud/tasks#1971 together with this PR here already gives a fully working app. See here:
Screenshot 2023-03-07 at 12-59-11 Aufgaben - Nextcloud

@raimund-schluessler raimund-schluessler force-pushed the vue3 branch 4 times, most recently from c6c9473 to d704e38 Compare January 30, 2023 13:47
@raimund-schluessler raimund-schluessler added 2. developing Work in progress technical debt breaking PR that requires a new major version labels Jan 30, 2023
@raimund-schluessler raimund-schluessler linked an issue Jan 30, 2023 that may be closed by this pull request
20 tasks
@raimund-schluessler raimund-schluessler force-pushed the vue3 branch 3 times, most recently from 2bc5375 to 39947fe Compare February 2, 2023 15:54
@raimund-schluessler

This comment was marked as resolved.

@raimund-schluessler raimund-schluessler added the vue 3 Related to the vue 3 migration label Sep 8, 2023
@raimund-schluessler raimund-schluessler force-pushed the vue3 branch 4 times, most recently from e0e34b5 to 807eaad Compare September 21, 2023 18:55
@raimund-schluessler raimund-schluessler force-pushed the vue3 branch 2 times, most recently from 08ad995 to 058dffe Compare September 27, 2023 17:57
@raimund-schluessler raimund-schluessler force-pushed the vue3 branch 3 times, most recently from 97e0cb4 to c0a9ae9 Compare October 8, 2023 12:41
@raimund-schluessler raimund-schluessler force-pushed the vue3 branch 4 times, most recently from 39b62b4 to 487b8f8 Compare October 14, 2023 11:16
@raimund-schluessler raimund-schluessler force-pushed the vue3 branch 5 times, most recently from c7e144d to 456a379 Compare November 2, 2023 05:27
@raimund-schluessler raimund-schluessler force-pushed the vue3 branch 2 times, most recently from 4c08838 to 9a5336e Compare November 16, 2023 12:10
@raimund-schluessler raimund-schluessler force-pushed the vue3 branch 2 times, most recently from 534c5fe to 75cd61e Compare November 28, 2023 21:23
Signed-off-by: Raimund Schlüßler <[email protected]>
@raimund-schluessler
Copy link
Contributor Author

The components are now fully migrated, so this PR is not needed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress breaking PR that requires a new major version technical debt vue 3 Related to the vue 3 migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Vue 3
5 participants