Revert "fix(NcAppNavigation): Wrap app navigation default slot with s…

…crollable container" This reverts commit 19e7f64. Signed-off-by: Christopher Ng <[email protected]>
nextcloud-libraries · Mar 6, 2024 · cebe6ea · cebe6ea
1 parent 04bc33f
commit cebe6ea
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 17 deletions.
diff --git a/src/components/NcAppNavigation/NcAppNavigation.vue b/src/components/NcAppNavigation/NcAppNavigation.vue
@@ -64,11 +64,7 @@ emit('toggle-navigation', {
 			class="app-navigation__content"
 			:inert="!open || undefined"
 			@keydown.esc="handleEsc">
-			<div v-if="$scopedSlots.default" class="app-navigation__body">
-				<!-- @slot Content within the nav, do NOT add NcModal/NcDialog inside this slot -->
-				<slot />
-			</div>
-
+			<slot />
 			<!-- List for Navigation li-items -->
 			<ul v-if="$scopedSlots.list" class="app-navigation__list">
 				<slot name="list" />
@@ -259,17 +255,6 @@ export default {
 		position: absolute;
 	}
 
-	&__body {
-		position: relative;
-		height: 100%;
-		width: 100%;
-		overflow-x: hidden;
-		overflow-y: auto;
-		box-sizing: border-box;
-		display: flex;
-		flex-direction: column;
-	}
-
 	&__content > ul,
 	&__list {
 		position: relative;

diff --git a/src/components/NcAppNavigationList/NcAppNavigationList.vue b/src/components/NcAppNavigationList/NcAppNavigationList.vue
@@ -63,11 +63,17 @@ ul.app-navigation-list { // Increase specificity over NcAppNavigation styles
 	position: relative;
 	height: fit-content;
 	width: 100%;
-	overflow: visible;
+	overflow: unset;
 	box-sizing: border-box;
 	display: flex;
 	flex-direction: column;
 	gap: var(--default-grid-baseline, 4px);
 	padding: var(--app-navigation-padding);
+
+	&:nth-last-of-type(2) {
+		// Fill remaining space before NcAppNavigation footer
+		height: 100%;
+		overflow: auto;
+	}
 }
 </style>