Skip to content

Commit

Permalink
fix(NcAppNavigationCaption): Make color main-text for accessibility
Browse files Browse the repository at this point in the history
Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
susnux committed Nov 29, 2023
1 parent 415f697 commit c2763e2
Showing 1 changed file with 60 additions and 45 deletions.
105 changes: 60 additions & 45 deletions src/components/NcAppNavigationCaption/NcAppNavigationCaption.vue
Original file line number Diff line number Diff line change
@@ -1,17 +1,19 @@
<docs>
```vue
<template>
<NcAppNavigationCaption
name="Your caption goes here">
<template #actions>
<NcActionButton>
<template #icon>
<Plus :size="20" />
</template>
This is an action
</NcActionButton>
</template>
</NcAppNavigationCaption>
<ul>
<NcAppNavigationCaption
name="Your caption goes here">
<template #actions>
<NcActionButton>
<template #icon>
<Plus :size="20" />
</template>
This is an action
</NcActionButton>
</template>
</NcAppNavigationCaption>
</ul>
</template>
<script>
import Plus from 'vue-material-design-icons/Plus'
Expand All @@ -22,43 +24,51 @@
},
}
</script>
<style scoped>
/* mock the appnavigation */
ul {
background-color: #cce6f4;
}
</style>
```

### Element with a slot for custom actions icon
```vue
<template>
<NcAppNavigationCaption
name="Your caption goes here">
<template #actionsTriggerIcon>
<Plus slot="icon" :size="20" />
</template>
<template #actions>
<NcActionButton>
<template #icon>
<Pencil :size="20" />
</template>
Rename
</NcActionButton>
<NcActionButton>
<template #icon>
<Delete :size="20" />
</template>
Delete
</NcActionButton>
<NcActionButton>
<template #icon>
<ArrowRight :size="20" />
</template>
Validate
</NcActionButton>
<NcActionButton>
<template #icon>
<Download :size="20" />
</template>
Download
</NcActionButton>
</template>
</NcAppNavigationCaption>
<ul>
<NcAppNavigationCaption
name="Your caption goes here">
<template #actionsTriggerIcon>
<Plus slot="icon" :size="20" />
</template>
<template #actions>
<NcActionButton>
<template #icon>
<Pencil :size="20" />
</template>
Rename
</NcActionButton>
<NcActionButton>
<template #icon>
<Delete :size="20" />
</template>
Delete
</NcActionButton>
<NcActionButton>
<template #icon>
<ArrowRight :size="20" />
</template>
Validate
</NcActionButton>
<NcActionButton>
<template #icon>
<Download :size="20" />
</template>
Download
</NcActionButton>
</template>
</NcAppNavigationCaption>
</ul>
</template>
<script>
import ArrowRight from 'vue-material-design-icons/ArrowRight'
Expand All @@ -77,6 +87,12 @@
}
}
</script>
<style scoped>
/* mock the appnavigation */
ul {
background-color: #cce6f4;
}
</style>
```

</docs>
Expand Down Expand Up @@ -146,13 +162,12 @@ export default {
&__name {
font-weight: bold;
color: var(--color-primary-element);
color: var(--color-main-text);
font-size: var(--default-font-size);
line-height: $clickable-area;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
opacity: $opacity_normal;
box-shadow: none !important;
flex-shrink: 0;
// padding to align the name with the icon of app navigation items
Expand Down

0 comments on commit c2763e2

Please sign in to comment.