Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing OC constant types #259

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix: Add missing OC constant types #259

merged 1 commit into from
Jun 25, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 24, 2024

Missing type from OC constants

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux added bug Something isn't working 3. to review labels Jun 24, 2024
@susnux susnux mentioned this pull request Jun 24, 2024
1 task
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hesitant approval because we shouldn't make the OC.* internals look like public/stable API

@susnux
Copy link
Contributor Author

susnux commented Jun 25, 2024

Hesitant approval because we shouldn't make the OC.* internals look like public/stable API

Agree but yet if we provide type we should make it complete

@susnux susnux merged commit fd57975 into master Jun 25, 2024
5 checks passed
@susnux susnux deleted the fix/oc-constants branch June 25, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants