Fix davResultToNode on public shares and provide isPublicShare helper

lib/dav/dav.ts

@@ -3,18 +3,20 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 import type { DAVResultResponseProps, FileStat, ResponseDataDetailed, WebDAVClient } from 'webdav'
-import { NodeStatus, type Node } from '../files/node'
+import type { Node } from '../files/node'
 
 import { File } from '../files/file'
 import { Folder } from '../files/folder'
+import { NodeStatus } from '../files/node'
 import { NodeData } from '../files/nodeData'
 import { davParsePermissions } from './davPermissions'
 import { davGetFavoritesReport } from './davProperties'
 
 import { getCurrentUser, getRequestToken, onRequestTokenUpdate } from '@nextcloud/auth'
 import { generateRemoteUrl } from '@nextcloud/router'
-import { createClient, getPatcher } from 'webdav'
 import { CancelablePromise } from 'cancelable-promise'
+import { createClient, getPatcher } from 'webdav'
+import { isPublicShare } from '../utils/isPublic'
 
 /**
  * Nextcloud DAV result response
@@ -137,12 +139,10 @@
  */
 export const davResultToNode = function(node: FileStat, filesRoot = davRootPath, remoteURL = davRemoteURL): Node {
 	let userId = getCurrentUser()?.uid
-	const isPublic = document.querySelector<HTMLInputElement>('input#isPublic')?.value
-	if (isPublic) {
-		userId = userId ?? document.querySelector<HTMLInputElement>('input#sharingUserId')?.value
+	if (isPublicShare()) {
 		userId = userId ?? 'anonymous'
 	} else if (!userId) {
 		throw new Error('No user id found')
 	}
 
 	const props = node.props as ResponseProps

lib/index.ts

@@ -22,6 +22,7 @@ export { Node, NodeStatus, type INode } from './files/node'
 
 export { isFilenameValid, getUniqueName } from './utils/filename'
 export { formatFileSize, parseFileSize } from './utils/fileSize'
+export { isPublicShare } from './utils/isPublic'
 export { orderBy } from './utils/sorting'
 export { sortNodes, FilesSortingMode, type FilesSortingOptions } from './utils/fileSorting'
 

lib/utils/isPublic.ts

@@ -0,0 +1,14 @@
+/**
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+import { loadState } from '@nextcloud/initial-state'
+
+/**
+ * Check if the current page is on a public share
+ */
+export function isPublicShare(): boolean {
+	// check both the new initial state version and fallback to legacy input
+	return loadState<boolean | null>('files_sharing', 'isPublic', null)
+		?? document.querySelector('input#isPublic[type="hidden"][name="isPublic"][value="1"]') !== null
+}

package.json

@@ -67,6 +67,7 @@
   },
   "dependencies": {
     "@nextcloud/auth": "^2.3.0",
+    "@nextcloud/initial-state": "^2.2.0",
     "@nextcloud/l10n": "^3.1.0",
     "@nextcloud/logger": "^3.0.2",
     "@nextcloud/paths": "^2.1.0",