Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sorting): The display name attribute is called displayname not displayName for DAV #992

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fix(sorting): The display name attribute is called displayname not displayName for DAV #992

merged 1 commit into from
Jun 18, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 18, 2024

Fix invalid usage of the display name property of DAV.

@susnux susnux added bug Something isn't working 3. to review labels Jun 18, 2024
@susnux susnux requested review from artonge, skjnldsv and Pytal June 18, 2024 13:13
@codecov Codecov
Copy link

codecov bot commented Jun 18, 2024

Bundle Report

Bundle size has no change ✅

skjnldsv
skjnldsv approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@skjnldsv skjnldsv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me, but careful here, I was unaware we had a displayName dav property, meaning the displayName camelCase had to come from somewhere, I would double check to be safe

@susnux
Copy link
Contributor Author

susnux commented Jun 18, 2024

Good for me, but careful here, I was unaware we had a displayName dav property, meaning the displayName camelCase had to come from somewhere, I would double check to be safe

I checked this and I would say it is just a typo because everything else (files view, actions etc) displayName is used, just DAV attribute is called displayname

@susnux susnux force-pushed the fix/files-displayname branch from e10cf57 to 15655d7 Compare June 18, 2024 15:38
@susnux
fix(sorting): The display name attribute is called displayname not …
450fb37 
…`displayName` for DAV

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the fix/files-displayname branch from 15655d7 to 450fb37 Compare June 18, 2024 15:40
@susnux susnux merged commit 078ca8d into main Jun 18, 2024
17 checks passed
@susnux susnux deleted the fix/files-displayname branch June 18, 2024 15:44
@skjnldsv skjnldsv mentioned this pull request Jul 2, 2024
Merged
@JhayceFrancis JhayceFrancis mentioned this pull request Aug 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@artonge artonge artonge approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @artonge @skjnldsv