Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dav): Add displayname and creationdate to default props #991

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 18, 2024

The two props were missing by default leading to problems where displayname is different from basename

@susnux susnux added bug Something isn't working 3. to review labels Jun 18, 2024
@susnux susnux requested review from artonge, skjnldsv and Pytal June 18, 2024 12:23
Copy link

codecov bot commented Jun 18, 2024

Bundle Report

Changes will increase total bundle size by 78 bytes ⬆️

Bundle name Size Change
@nextcloud/files-esm 95.19kB 39 bytes ⬆️
@nextcloud/files-esm-cjs 96.27kB 39 bytes ⬆️

@susnux susnux changed the title fix(dav): Add displayname to default props fix(dav): Add displayname and creationdate to default props Jun 18, 2024
@susnux susnux force-pushed the fix/add-missing-default-props branch from dd7e740 to 5ecd5e3 Compare June 18, 2024 13:10
@susnux susnux requested a review from skjnldsv June 18, 2024 13:13
@skjnldsv skjnldsv merged commit 5b48fac into main Jun 18, 2024
17 checks passed
@skjnldsv skjnldsv deleted the fix/add-missing-default-props branch June 18, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants