Fixed deprecation warning Node.attributes.displayname should be accessed directly on the Node

[dvaerum]

Hey Nextcloud people.

I can see that I get a lot of these warning in the console of my browser (Firefox). They are floating my console so much that it prevents me from using it to find another bug/issue/problem on Nextcloud 😓

[WARN] @nextcloud/files: Accessing "Node.attributes.displayname" is deprecated, access it directly on the Node instance. 
Object { app: "@nextcloud/files", uid: "dvaerum", level: 2 }
[index.mjs:51:16](webpack:///nextcloud/node_modules/@nextcloud/logger/dist/index.mjs)

and I believe that I have traced it down to this line

nextcloud-files/lib/utils/fileSorting.ts

Line 68 in ae0a991

(v: INode) => basename(v.attributes?.displayname || v.basename),

Which uses v.attributes?.displayname instead of v.displayname.

Sorry, I don't follow the contributor guidelines, but I did not see any.

[skjnldsv]

Thanks Denis! We'll investigate :)

[susnux]

makes sense

There is a problem if there is an outdated app that uses a library version that does not provide displayname

[dvaerum]

Hey @susnux

Do you know there I find the rules for commit messages because it looks like I need to update one of them

Block unconventional commits / Block unconventional commits (pull_request) 

It is obvious what I need to correct 😕

[susnux]

Yes please squash you commits and use conventional commits like:
fix(sorting): access displayname directly on Node

See https://www.conventionalcommits.org/en/v1.0.0/

[dvaerum]

Hey @susnux

I believe that I have fixed the commit names. I didn't find your YAML config for configuring git-conventional-commits, so I just went with the one used in the example here:
https://github.com/qoomon/git-conventional-commits?tab=readme-ov-file#config-file