enh: breadcrumbs are now consistant across server #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Morales <[email protected]>
|
But it is not all files but home or start or what ever you call the root? |
|
@susnux I see what you mean! Both cases work well here, tbh. We can leave the regular name be "Home" (or root) here, as it does convey where the file picker is searching from, but IMO "All files" lets the user instantly know they are looking through all possible files, and is consistent design wise with the breadcrumbs that will be on If you still believe we can leave it how it is currently / don't believe this change is a net positive, then let me know and I can pull this PR down :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coincides with nextcloud/server#43604
Instead of "Home", breadcrumb name is now "All files". Changed this to be more consistent across the server :)
PLACE TO CHANGE: Section that says "Home"
