fix(FilePicker): Improve choose button text when selecting multiple #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
fix/improve-choose-button
branch
from
f449566 to
7d1be6f
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/improve-choose-button
branch
from
7d1be6f to
76fe2ae
Compare
come-nc
approved these changes
Jan 18, 2024
|
But it also change |
Nope, my bad, it does not. It’s weird that the multiversions has plural and singular but I suppose it’s needed for other languages. |
yes there are languages with more plural forms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of only showing
Choose FIRST FILEor justChooseshowChoose 3 fileswhen multiselect is enabled.