Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FilePicker): Use Node::path for current path fixing an clicking favorite folders #1165

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 10, 2024

given:

/
 a-folder/
           favorite ⭐

if you now go to favorites view an click the folder favorite the path was set to /favorite which is invalid.

@susnux susnux added bug Something isn't working 3. to review labels Jan 10, 2024
@susnux susnux added this to the 5.0.0 milestone Jan 10, 2024
@susnux susnux requested review from skjnldsv and ShGKme January 10, 2024 14:50
… favorite folders

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the fix/filepicker-path branch from 8f3c272 to 3ba5941 Compare January 10, 2024 14:51
@susnux
Copy link
Contributor Author

susnux commented Jan 10, 2024

/backport 3ba5941 to stable4

@susnux susnux modified the milestones: 5.0.0, 5.0.4 Jan 10, 2024
@skjnldsv skjnldsv merged commit 9f68d65 into main Jan 10, 2024
10 checks passed
@skjnldsv skjnldsv deleted the fix/filepicker-path branch January 10, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Copy/ Move files to a nested favorite folder returns 404 error
2 participants