Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FilePicker): Set default of path to undefined to allow using the saved path #1137

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Dec 7, 2023

Bring back the "saved path" or "last path" feature.

The property should default to undefined to the check in the computed property (currentPath) can use the last saved path as a fallback.

@susnux susnux added bug Something isn't working 3. to review labels Dec 7, 2023
@susnux susnux added this to the 5.0.0 milestone Dec 7, 2023
@susnux susnux requested review from artonge, skjnldsv and Pytal December 7, 2023 15:37
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9445962) 30.61% compared to head (5a800bb) 30.61%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1137   +/-   ##
=======================================
  Coverage   30.61%   30.61%           
=======================================
  Files          16       16           
  Lines        1225     1225           
  Branches       60       60           
=======================================
  Hits          375      375           
  Misses        792      792           
  Partials       58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skjnldsv skjnldsv merged commit 56199c2 into main Dec 8, 2023
11 checks passed
@skjnldsv skjnldsv deleted the fix/saving-last-path branch December 8, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants