Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FilePicker): cropImagePreviews is now provided as a prop in FilePreview #1120

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 23, 2023

We need to use the property instead of the previous available reference for cropImagePreviews.

@susnux susnux added bug Something isn't working regression 3. to review labels Nov 23, 2023
@susnux susnux requested review from Pytal and artonge November 23, 2023 19:58
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8971fc5) 30.49% compared to head (83af02d) 30.61%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1120      +/-   ##
==========================================
+ Coverage   30.49%   30.61%   +0.11%     
==========================================
  Files          16       16              
  Lines        1223     1225       +2     
  Branches       60       60              
==========================================
+ Hits          373      375       +2     
  Misses        792      792              
  Partials       58       58              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pytal Pytal merged commit 741a6ee into main Nov 23, 2023
11 checks passed
@Pytal Pytal deleted the fix/cropImagePreviews-not-defined branch November 23, 2023 20:20
@nickvergessen
Copy link
Contributor

5.0.3 incoming for the final releases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing previews in file picker?
3 participants