Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add sandpack to /configuration/pages examples #4169

Closed
wants to merge 10 commits into from

Conversation

ndom91
Copy link
Member

@ndom91 ndom91 commented Mar 12, 2022

Based upon the initial @codesandbox/sandpack support, added it to our /configuration/pages page to allow users to customize and play with the custom pages support, as well as theming.

STILL WIP ATM - Having issues with the custom files / custom dependency setup.

See: https://next-auth-git-ndom91-add-sandpack-custom-page-c606fc-nextauthjs.vercel.app/configuration/pages

Notes:

Reasoning 💡

Checklist 🧢

  • Documentation
  • Tests
  • Ready to be merged

Affected issues 🎟

@vercel
Copy link

vercel bot commented Mar 12, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/nU9XAEhishh26xEpCLXRMULtnbZr
✅ Preview: https://next-auth-git-ndom91-add-sandpack-custom-page-c606fc-nextauthjs.vercel.app

[Deployment for d8fa183 canceled]

dependencies: {
react: "17.0.2",
"react-dom": "17.0.2",
next: "^12.0.11-canary.4",
Copy link
Contributor

@danilowoz danilowoz Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I'm sorry if I didn't make myself very clear in this commentary and here. Sandpack doesn't support any dependency that needs a server to run (but only runtime projects). I thought you had different purposes for Sandpack here and that's why I didn't want to discourage this integration, however I'm afraid to say that CodeSandbox Embed is still the best option.

I also addressed this issue on Sandpack project, to avoid this kind of assumption again codesandbox/sandpack#410

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes you're right, must have forgotten that piece. Thanks anyway for all the support so far!

@ndom91
Copy link
Member Author

ndom91 commented Mar 22, 2022

Closing this for now!

@ndom91 ndom91 closed this Mar 22, 2022
@balazsorban44 balazsorban44 deleted the ndom91/add-sandpack-custom-pages-playground branch December 3, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants