Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Test Docusaurus webpack 5 support #1826

Merged
merged 6 commits into from
May 12, 2021
Merged

chore: Test Docusaurus webpack 5 support #1826

merged 6 commits into from
May 12, 2021

Conversation

slorber
Copy link
Contributor

@slorber slorber commented Apr 23, 2021

Use an unreleased version of Docusaurus to test the webpack5 support works for this site.

See also facebook/docusaurus#4089

@vercel
Copy link

vercel bot commented Apr 23, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/F6HN2tFBGdYkp5BKaKK3ib7Ktdvs
✅ Preview: https://next-auth-git-fork-slorber-slorber-docu-nextauthjs.vercel.app

@vercel vercel bot temporarily deployed to Preview April 23, 2021 17:19 Inactive
@github-actions github-actions bot added the docs Relates to documentation label Apr 23, 2021
@slorber slorber mentioned this pull request Apr 23, 2021
Merged
@balazsorban44 balazsorban44 mentioned this pull request Apr 24, 2021
Closed
15 tasks
@balazsorban44
Copy link
Member

@slorber thank you for this, I'm interested in how it will go!

@slorber slorber mentioned this pull request May 1, 2021
Closed
@balazsorban44 balazsorban44 mentioned this pull request May 5, 2021
Closed
@balazsorban44
Copy link
Member

@slorber just curious, what should we expect from this PR? Is it faster builds, anything else? What is the status and your intent here? Is this something you plan to work on, or was just a test of some kind? 😊

@slorber
Copy link
Contributor Author

slorber commented May 6, 2021

@balazsorban44 unfortunately out of 20 similar PR, this one is the only one blocked by an issue in the lunr search plugin you use: praveenn77/docusaurus-lunr-search#52

Waiting for the author to answer, unless you are willing to use a fork or patch-package.

@balazsorban44
Copy link
Member

No rush, I was just curious if there was activity here 🙂 Happy to wait!

@vercel vercel bot temporarily deployed to Preview May 11, 2021 08:45 Inactive
@slorber
Merge branch 'main' into slorber/docu
37ec60b 
# Conflicts:
#	www/package-lock.json
@vercel vercel bot temporarily deployed to Preview May 11, 2021 08:48 Inactive
@slorber slorber marked this pull request as ready for review May 11, 2021 08:52
@slorber
Copy link
Contributor Author

slorber commented May 11, 2021

Ready for review :)

@balazsorban44 balazsorban44 requested a review from 0ubbe May 11, 2021 13:31
balazsorban44
balazsorban44 approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked it locally, and it seems it also fixed the #1935 problem, but I would like @lluia to have a look as well!

LGTM!

0ubbe
0ubbe requested changes May 11, 2021
View reviewed changes
Copy link
Collaborator

@0ubbe 0ubbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side too 💚 , just a small suggestion about the scripts 👍🏽

www/package.json Show resolved Hide resolved
www/package.json Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview May 12, 2021 07:42 Inactive
@balazsorban44 balazsorban44 merged commit c823016 into nextauthjs:main May 12, 2021
@balazsorban44
Copy link
Member

balazsorban44 commented May 12, 2021 •
edited
Loading

@slorber Something is not right... I merged it to main, but I now reverted the deployment to a previous version. Any ideas what happened? It looked good locally, and also on the preview URL at https://next-auth-git-fork-slorber-slorber-docu-nextauthjs.vercel.app/

balazsorban44 added a commit that referenced this pull request May 12, 2021
@balazsorban44
Revert "docs(www): update Docusaurus to webpack 5 (#1826)"
cbaad5f 
This reverts commit c823016.
@balazsorban44 balazsorban44 mentioned this pull request May 12, 2021
Merged
@slorber
Copy link
Contributor Author

slorber commented May 12, 2021

@balazsorban44 do you have the url of the failing deployment?

If this happens, it is possibly due to a network error or the CDN cache temporarily returning an error

@balazsorban44
Copy link
Member

balazsorban44 commented May 12, 2021 •
edited
Loading

I don't think I can share the actual deployment from Vercel, but here is the build log:

09:42:08.226 Cloning github.com/nextauthjs/next-auth (Branch: slorber/docu, Commit: 8e6a10b)
09:42:09.268 Cloning completed: 1.041s
09:42:09.307 Analyzing source code...
09:42:10.569 Installing build runtime...
09:42:12.494 Build runtime installed: 1.925s
09:42:15.221 Looking up build cache...
09:42:15.389 Build cache found. Downloading...
09:42:17.011 Build cache downloaded [30.40 MB]: 1621.790ms
09:42:18.244 Detected package.json
09:42:18.244 Installing dependencies...
09:42:24.157 npm WARN @docsearch/[email protected] requires a peer of @types/react@>= 16.8.0 < 18.0.0 but none is installed. You must install peer dependencies yourself.
09:42:24.163 npm WARN [email protected] requires a peer of react@^16.8.4 but none is installed. You must install peer dependencies yourself.
09:42:24.168 npm WARN [email protected] requires a peer of react-dom@^16.8.4 but none is installed. You must install peer dependencies yourself.
09:42:24.172 npm WARN [email protected] No description
09:42:24.176 npm WARN [email protected] No repository field.
09:42:24.180 npm WARN [email protected] No license field.
09:42:24.188 npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
09:42:24.188 npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
09:42:24.195 npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/webpack-dev-server/node_modules/fsevents):
09:42:24.195 npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
09:42:24.195 updated 1 package in 5.47s
09:42:24.723 218 packages are looking for funding
09:42:24.723 run npm fund for details
09:42:24.933 Running "npm run build"
09:42:25.139 > [email protected] build /vercel/path0/www
09:42:25.139 > npm run generate-providers && docusaurus build
09:42:25.344 > [email protected] generate-providers /vercel/path0/www
09:42:25.344 > node ./scripts/generate-providers.js
09:42:26.728 [en] Creating an optimized production build...
09:42:27.470 ℹ Compiling Client
09:42:27.487 ℹ Compiling Server
09:42:31.661 ✔ Client: Compiled successfully in 4.19s
09:42:33.764 Component Image was not imported, exported, or provided by MDXProvider as global scope
09:42:35.479 ✔ Server: Compiled successfully in 7.99s
09:42:35.736 docusaurus-lunr-search:: Building search docs and lunr index file
09:42:35.758 docusaurus-lunr-search:: Start scanning documents in 4 threads
09:42:37.197 docusaurus-lunr-search:: Indexing time: 1460.351ms
09:42:37.197 docusaurus-lunr-search:: indexed 74 documents out of 75
09:42:37.198 docusaurus-lunr-search:: writing search-doc.json
09:42:37.199 docusaurus-lunr-search:: writing search-doc-1620805346885.json
09:42:37.262 docusaurus-lunr-search:: writing lunr-index.json
09:42:37.262 docusaurus-lunr-search:: writing lunr-index-1620805346885.json
09:42:37.263 docusaurus-lunr-search:: End of process
09:42:37.386 Success! Generated static files in build.
09:42:37.386 Use npm run serve to test your build locally.
09:42:37.986 Uploading build outputs...
09:42:39.225 Deploying build outputs...
09:42:44.548 Build completed. Populating build cache...
09:42:54.628 Uploading build cache [30.05 MB]...
09:42:55.237 Build cache uploaded: 604.937ms
09:42:55.751 Done with "package.json"

So you suggest that it was only temporary?

@slorber
Copy link
Contributor Author

slorber commented May 12, 2021

Normally you have a unique deploy url from Vercel.

Yes I think it is temporary (or a bad CDN cache config if you have any?).
You can inspect the network tab: js/css assets fail to load for some reason. Wonder what is the HTTP code returned, it might be a 500.

@balazsorban44 balazsorban44 mentioned this pull request May 12, 2021
Merged
@balazsorban44
Copy link
Member

balazsorban44 commented May 12, 2021 •
edited
Loading

@slorber you were right, it might have been some kind of temporary issue. I reverted my reverted commit, and now everything looks fine on https://next-auth.js.org/ 🎉

@slorber
Copy link
Contributor Author

slorber commented May 13, 2021

Great!

Will improve the banner message to mention it is possibly a network or CDN error

mnphpexpert added a commit to mnphpexpert/next-auth that referenced this pull request Sep 2, 2024
@mnphpexpert @0ubbe
docs(www): update Docusaurus to webpack 5 (nextauthjs#1826)
9f537b9 
* upgrade

* upgrade

* fix lunr plugin bug

Co-authored-by: Lluis Agusti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@0ubbe 0ubbe 0ubbe approved these changes

Assignees
No one assigned
Labels
docs Relates to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slorber @balazsorban44 @0ubbe