fix(email): allow for custom http mail implementations off of nodemailer #11686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
JipSterk
changed the title
JipSterk
changed the title
|
@ndom91 is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
ndom91
changed the title
ndom91
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11686 +/- ##
=======================================
Coverage 39.34% 39.34%
=======================================
Files 185 185
Lines 29350 29350
Branches 1270 1270
=======================================
Hits 11549 11549
Misses 17801 17801 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
currently solutions using a custom configuration of sendVerificationRequest for the nodemailer provider still require a server config object passed even though it's type is not mandatory which is not need for implementations that for example use a sdk like aws-ses or react-email
🧢 Checklist
🎫 Affected issues
Fixes: #10376 (comment)
📌 Resources