Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed admin_messages in frontend, fixes #940 #1508

Merged
merged 2 commits into from
Sep 26, 2018

Conversation

sprankhub
Copy link
Contributor

Following up on #940 here. The distinction between getHtml for the global_messages and getGroupedHtml for the messages is quite old:

https://github.com/nexcess/magento-turpentine/blame/44d7b7627b2656ae87aa29b5a6a52e4e774fd33d/app/code/community/Nexcessnet/Turpentine/Block/Core/Messages.php#L319-L327

It should be absolutely okay to always use getGroupedHtml:

  • for the messages, getGroupedHtml is already used, so nothing changes for this block
  • the global_messages block is always called via <?php echo $this->getChildHtml('global_messages') ?>
  • Mage_Core_Block_Abstract::getChildHtml calls Mage_Core_Block_Abstract::_getChildHtml
  • Mage_Core_Block_Abstract::_getChildHtml calls Mage_Core_Block_Abstract::toHtml
  • Mage_Core_Block_Abstract::toHtml calls Mage_Core_Block_Messages::_toHtml
  • Mage_Core_Block_Messages::_toHtml always uses Mage_Core_Block_Messages::getGroupedHtml - hence, we can use it as well

@miguelbalparda miguelbalparda changed the base branch from master to devel September 12, 2018 09:14
@miguelbalparda miguelbalparda self-assigned this Sep 12, 2018
@sprankhub
Copy link
Contributor Author

Any idea when this can be merged @miguelbalparda?

@miguelbalparda miguelbalparda merged commit 9900bf3 into nexcess:devel Sep 26, 2018
@sprankhub sprankhub deleted the patch-2 branch September 26, 2018 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants