fixed admin_messages in frontend, fixes #940 #1508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #940 here. The distinction between
getHtml
for theglobal_messages
andgetGroupedHtml
for themessages
is quite old:https://github.com/nexcess/magento-turpentine/blame/44d7b7627b2656ae87aa29b5a6a52e4e774fd33d/app/code/community/Nexcessnet/Turpentine/Block/Core/Messages.php#L319-L327
It should be absolutely okay to always use
getGroupedHtml
:messages
,getGroupedHtml
is already used, so nothing changes for this blockglobal_messages
block is always called via<?php echo $this->getChildHtml('global_messages') ?>
Mage_Core_Block_Abstract::getChildHtml
callsMage_Core_Block_Abstract::_getChildHtml
Mage_Core_Block_Abstract::_getChildHtml
callsMage_Core_Block_Abstract::toHtml
Mage_Core_Block_Abstract::toHtml
callsMage_Core_Block_Messages::_toHtml
Mage_Core_Block_Messages::_toHtml
always usesMage_Core_Block_Messages::getGroupedHtml
- hence, we can use it as well