Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TMRS-586): add heights to opta widgets #4012

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

douglasmik
Copy link
Contributor

@douglasmik douglasmik commented Dec 18, 2024

Description

  • Height attribute added to OPTA widgets. Where this is fixed, as with the OptaFootballFixturesTicker the height has been entered as the default value.
  • Support for breakpoint specific height attributes have been added to our iframe component;
    e.g.
attributes: {
  ...
  height: {
    xs: number;
    sm: number;
    md: number;
    lg: number;
  }
}

NB: These height values will need to be configured in NewsPress for use in articles.

TMRS-586

Checklist

  • Have you done any manual testing?
  • Does it have automated tests?
  • Do you need any other PRs merged before this (if so please list)?
  • Do you need to update the README/Runbook
  • Have you checked for accessibility?

Screenshots (if appropriate):

Include screenshots if needed.

@douglasmik douglasmik requested a review from a team as a code owner December 18, 2024 10:02
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
28.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants