Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CPNT-2252) PHPMD config #1

Merged
merged 9 commits into from
Jan 15, 2024
Merged

Conversation

mohanrajpac
Copy link
Contributor

  • Adds PHPMD config with WP related rulesets.

@mohanrajpac mohanrajpac requested a review from a team January 2, 2024 15:43
README.md Outdated Show resolved Hide resolved
ruleset.xml Outdated Show resolved Hide resolved
ruleset.xml Outdated Show resolved Hide resolved
ruleset.xml Outdated Show resolved Hide resolved
ruleset.xml Show resolved Hide resolved
ruleset.xml Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
Copy link

@jonnynews jonnynews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.circleci/config.yml Outdated Show resolved Hide resolved
@mohanrajpac mohanrajpac requested a review from jonnynews January 15, 2024 12:44
jonnynews
jonnynews previously approved these changes Jan 15, 2024
Copy link

@jonnynews jonnynews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonnynews
Copy link

@mohanrajpac Can you copy this dependabot.yml file into this repo as well? I believe that dependabot needs to be activated in github settings.

jonnynews
jonnynews previously approved these changes Jan 15, 2024
Copy link

@shadi-sharaf-nuk shadi-sharaf-nuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with minor suggestion.

README.md Outdated Show resolved Hide resolved
@mohanrajpac mohanrajpac merged commit 9045ab5 into main Jan 15, 2024
1 check passed
@mohanrajpac mohanrajpac deleted the chore/CPNT-2252-phpmd-config branch January 15, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants