Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure archive pageand generic changes #18

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

cchiremath123
Copy link
Collaborator

Changes for Home, Archive, Article, Issue, Explore, Generic Pages

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cchiremath123, i am seeing a couple of test cases failing on the homepage
1)Book review popup
2)Issue page validation
Screenshot 2025-01-17 at 14 14 10
Screenshot 2025-01-17 at 14 14 16

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this empty file

export const navigateToCurrentIssuePage=()=> {
cy.get( CurrentIssue_PAGE_ELEMENT_ON_HOME_PAGE ).eq( 0 ).should( 'have.text', 'Current Issue' );
cy.get( CurrentIssue_PAGE_ELEMENT_ON_HOME_PAGE ).eq( 0 ).click();
cy.url().should( 'contain', 'https://www.the-tls.co.uk/issues/current-issue' );
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have hardcoded the prod value, so the test cases are not passing on UAT. Please fix this

Screenshot 2025-01-17 at 14 24 20

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1)please fix the failing test case.
Screenshot 2025-01-17 at 14 24 20
2)please add the missing test case here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants