Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use website url for ext-projects when available #467

Merged
merged 3 commits into from
Jun 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/__tests__/__snapshots__/Header.spec.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Array [
>
<a
className="leftSideLink"
href="#"
href="/"
>
Open Source
</a>
Expand Down
4 changes: 2 additions & 2 deletions src/pages/__tests__/__snapshots__/collection.spec.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ exports[`Data Collection Agents Page Renders correctly 1`] = `
>
<a
className="leftSideLink"
href="#"
href="/"
>
Open Source
</a>
Expand Down Expand Up @@ -289,7 +289,7 @@ exports[`Data Collection Agents Page Renders correctly 1`] = `
className="version footerMeta"
>
Version
1.0.3
1.0.10
</small>
</div>
</section>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ exports[`External Projects Page Renders correctly 1`] = `
>
<a
className="leftSideLink"
href="#"
href="/"
>
Open Source
</a>
Expand Down Expand Up @@ -254,7 +254,7 @@ exports[`External Projects Page Renders correctly 1`] = `
className="version footerMeta"
>
Version
1.0.3
1.0.10
</small>
</div>
</section>
Expand Down
4 changes: 2 additions & 2 deletions src/pages/__tests__/__snapshots__/index.spec.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ exports[`HomePage Renders correctly 1`] = `
>
<a
className="leftSideLink"
href="#"
href="/"
>
Open Source
</a>
Expand Down Expand Up @@ -394,7 +394,7 @@ exports[`HomePage Renders correctly 1`] = `
className="version footerMeta"
>
Version
1.0.3
1.0.10
</small>
</div>
</section>
Expand Down
4 changes: 2 additions & 2 deletions src/pages/__tests__/__snapshots__/oss-category.spec.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ exports[`OSS Category Page Renders correctly 1`] = `
>
<a
className="leftSideLink"
href="#"
href="/"
>
Open Source
</a>
Expand Down Expand Up @@ -510,7 +510,7 @@ exports[`OSS Category Page Renders correctly 1`] = `
className="version footerMeta"
>
Version
1.0.3
1.0.10
</small>
</div>
</section>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ exports[`Adopt OpenJDK Renders correctly 1`] = `
>
<a
className="leftSideLink"
href="#"
href="/"
>
Open Source
</a>
Expand Down Expand Up @@ -315,7 +315,7 @@ exports[`Adopt OpenJDK Renders correctly 1`] = `
className="version footerMeta"
>
Version
1.0.3
1.0.10
</small>
</div>
</section>
Expand Down Expand Up @@ -361,7 +361,7 @@ exports[`Open Telemetry Page Renders correctly 1`] = `
>
<a
className="leftSideLink"
href="#"
href="/"
>
Open Source
</a>
Expand Down Expand Up @@ -638,7 +638,7 @@ exports[`Open Telemetry Page Renders correctly 1`] = `
className="version footerMeta"
>
Version
1.0.3
1.0.10
</small>
</div>
</section>
Expand Down Expand Up @@ -684,7 +684,7 @@ exports[`W3C Distributed Tracing Working Group Renders correctly 1`] = `
>
<a
className="leftSideLink"
href="#"
href="/"
>
Open Source
</a>
Expand Down Expand Up @@ -1189,7 +1189,7 @@ exports[`W3C Distributed Tracing Working Group Renders correctly 1`] = `
className="version footerMeta"
>
Version
1.0.3
1.0.10
</small>
</div>
</section>
Expand Down
3 changes: 2 additions & 1 deletion src/templates/external-project-page.js
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,8 @@ const ExternalProjectPage = ({ data }) => {
<div className={styles.callToActionButtons}>
<div className={styles.callToActionButtonsContainer}>
<a
href={`${project.githubUrl}`}
href={`${get(project, ['website', 'url'], '') ||
project.githubUrl}`}
className="button button-primary"
target="__blank"
rel="noopener noreferrer"
Expand Down