Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nerdpack layout .json files need icons specified #422

Closed
danielgolden opened this issue Jun 10, 2020 · 3 comments
Closed

Nerdpack layout .json files need icons specified #422

danielgolden opened this issue Jun 10, 2020 · 3 comments
Labels
bug Something isn't working released

Comments

@danielgolden
Copy link
Contributor

Description

For example, the project page standard layout nerdpack (and probably all of those layout nerdpacks) has an launcher icon but it's not displayed at the top of the page (instead the placeholder icon is displayed).

Steps to Reproduce

View any of the layout nerdpack project pages.

Expected Behaviour

That the launcher icons for these projects would be displayed on the project page or in search results.

Relevant Console output

Your Environment

  • Browser name and version: Chrome 83.0.4103.61 (Build oficial) (64 bits)
  • Operating System and version: Mac OS Catalina 10.15.4 (19E287)
@danielgolden danielgolden added the bug Something isn't working label Jun 10, 2020
@tangollama
Copy link
Contributor

tangollama commented Jun 11, 2020 •
edited
Loading

@danielgolden that's not a bug. The iconUrl is null. You need to set that value to the path to the icon. For instance: https://github.com/newrelic/nr1-observability-maps/blob/master/icon.png?raw=true in https://github.com/newrelic/opensource-website/blob/develop/src/data/projects/newrelic-nr1-observability-maps.json

@danielgolden
Copy link
Contributor Author

ooohh, Ok. I'll do that 👍

@danielgolden danielgolden changed the title Some project page icons are not being displayed Nerdpack layout .json files need icons specified Jun 11, 2020
github-actions bot pushed a commit that referenced this issue Jun 15, 2020
@semantic-release-bot
chore(release): 0.5.4
fe9ebc5 
## [0.5.4](v0.5.3...v0.5.4) (2020-06-15)

### Bug Fixes

* **layout nerdpacks:** specify icon for each ([491d6dc](491d6dc)), closes [#422](#422)
* two-way sync between docs and wiki ([237ed68](237ed68))
@nr-opensource-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.5.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

jbeveland27 pushed a commit that referenced this issue Jun 15, 2020
@jbeveland27
fix(layout nerdpacks): specify icon for each
cdbe98d 
resolves #422
jbeveland27 pushed a commit that referenced this issue Jun 15, 2020
@semantic-release-bot @jbeveland27
chore(release): 0.5.4
adbb536 
## [0.5.4](v0.5.3...v0.5.4) (2020-06-15)

### Bug Fixes

* **layout nerdpacks:** specify icon for each ([491d6dc](491d6dc)), closes [#422](#422)
* two-way sync between docs and wiki ([237ed68](237ed68))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danielgolden @tangollama @nr-opensource-bot