Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add masterauth to inventory #42

Conversation

rabbitt
Copy link
Contributor

@rabbitt rabbitt commented Aug 2, 2019

Description of the changes

Treats masterauth like requirepass, obfuscating the password in the inventory list.

PR Review Checklist

Author

  • add a risk label after carefully considering the "blast radius" of your changes
  • describe the intent of your changes in the description. don't just rewrite your code in prose
  • assign at least one reviewer

Reviewer

  • review code for readability
  • verify that high risk behavior changes are well tested
  • check license for any new external dependency
  • ask questions about anything that isn't clear and obvious
  • approve the PR when you consider it's good to merge

@rabbitt
Copy link
Contributor Author

rabbitt commented Aug 2, 2019

This relates to #41

@mariomac mariomac changed the base branch from master to fix-masterauth August 5, 2019 09:15
@mariomac
Copy link
Contributor

mariomac commented Aug 5, 2019

Merging it into a feature branch to fix the format errors.

@mariomac mariomac merged commit b4c8b6a into newrelic:fix-masterauth Aug 5, 2019
@rabbitt rabbitt deleted the bugfix/hide-masterauth-in-inventory branch August 5, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants