Feat : resolved review comments (#62)

resolved : review comments --------- Co-authored-by: Jyothi Surampudi <[email protected]> Co-authored-by: jsurampudi <[email protected]> Co-authored-by: Rahul Reddy <[email protected]>
newrelic · Jan 28, 2025 · 2bf940a · 2bf940a
1 parent 4ed8799
commit 2bf940a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 21 deletions.
diff --git a/src/query-performance-monitoring/common-utils/common_helpers.go b/src/query-performance-monitoring/common-utils/common_helpers.go
@@ -14,23 +14,15 @@ import (
 // re is a regular expression that matches single-quoted strings, numbers, or double-quoted strings
 var re = regexp.MustCompile(`'[^']*'|\d+|".*?"`)
 
-func GetQuotedStringFromArray(array []string) string {
-	var quotedNames = make([]string, 0)
-	for _, name := range array {
-		quotedNames = append(quotedNames, fmt.Sprintf("'%s'", name))
-	}
-	return strings.Join(quotedNames, ",")
-}
-
 func GetDatabaseListInString(dbMap collection.DatabaseList) string {
-	var databaseNames = make([]string, 0)
-	for dbName := range dbMap {
-		databaseNames = append(databaseNames, dbName)
-	}
-	if len(databaseNames) == 0 {
+	if len(dbMap) == 0 {
 		return ""
 	}
-	return GetQuotedStringFromArray(databaseNames)
+	var quotedNames = make([]string, 0)
+	for dbName := range dbMap {
+		quotedNames = append(quotedNames, fmt.Sprintf("'%s'", dbName))
+	}
+	return strings.Join(quotedNames, ",")
 }
 
 func AnonymizeQueryText(query string) string {

diff --git a/src/query-performance-monitoring/common-utils/common_helpers_test.go b/src/query-performance-monitoring/common-utils/common_helpers_test.go
@@ -10,13 +10,6 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-func TestGetQuotedStringFromArray(t *testing.T) {
-	input := []string{"db1", "db2", "db3"}
-	expected := "'db1','db2','db3'"
-	result := commonutils.GetQuotedStringFromArray(input)
-	assert.Equal(t, expected, result)
-}
-
 func TestGetDatabaseListInString(t *testing.T) {
 	dbListKeys := []string{"db1"}
 	sort.Strings(dbListKeys) // Sort the keys to ensure consistent order