Integration test and static main improvements #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadiamoe
force-pushed
the
integration-test-improvements
branch
4 times, most recently
from
d4a6495 to
f0428da
Compare
nadiamoe
force-pushed
the
integration-test-improvements
branch
2 times, most recently
from
4a16a3a to
f0a600f
Compare
kubernetes-static main has been migrated to the new backbone as well Signed-off-by: Roberto Santalla <[email protected]>
Signed-off-by: Roberto Santalla <[email protected]>
Asserter is a (hopefully) powerful tool to assert that all metrics defined in a SpecGroup are correctly captured. Signed-off-by: Roberto Santalla <[email protected]>
Signed-off-by: Roberto Santalla <[email protected]>
Signed-off-by: Roberto Santalla <[email protected]>
Signed-off-by: Roberto Santalla <[email protected]>
Signed-off-by: Roberto Santalla <[email protected]>
Signed-off-by: Roberto Santalla <[email protected]>
nadiamoe
force-pushed
the
integration-test-improvements
branch
from
a1fd85d to
9a20034
Compare
| // AllVersions returns a list of versions we have test data for. | ||
| func AllVersions() []Version { | ||
| return []Version{ | ||
| Testdata116, |
There was a problem hiding this comment.
should we add a comment saying to which KSM version corresponds to each of these?
There was a problem hiding this comment.
Yep, this is something I though about. My plan is to overwrite all the static files so all of them use the KSM we support, but in the future we might want to have weirder versions.
There was a problem hiding this comment.
I will add a comment explaining this, and in the future, when I write the script to generate these files, I will keep in midn to log the version used somewhere.
…pers with objects\ fixup! add namespaces
nadiamoe
force-pushed
the
integration-test-improvements
branch
from
40392a5 to
d7fd3b6
Compare
I've added comments explaining how this works, which will hopefully improve readability.
paologallinaharbur
approved these changes
Nov 18, 2021
16 tasks
paologallinaharbur
pushed a commit
that referenced
this pull request
Jan 14, 2022
* test: new integration testing backbone kubernetes-static main has been migrated to the new backbone as well Signed-off-by: Roberto Santalla <[email protected]> * test/integration: make Version object return mocks Signed-off-by: Roberto Santalla <[email protected]> * test/integration: implement the Asserter Asserter is a (hopefully) powerful tool to assert that all metrics defined in a SpecGroup are correctly captured. Signed-off-by: Roberto Santalla <[email protected]> * test/integration: implement helper for building integrations Signed-off-by: Roberto Santalla <[email protected]> * test/asserter: log missing metric namespace Signed-off-by: Roberto Santalla <[email protected]> * test/asserter: make asserter fully thread-safe Signed-off-by: Roberto Santalla <[email protected]> * test/ksm: optimize asserter calls on test parallelization Signed-off-by: Roberto Santalla <[email protected]> * fixup! test/asserter: typos Signed-off-by: Roberto Santalla <[email protected]> * testutil: make LatestVersion rely on the order of AllVersions * testutil: do not wrap fake.NewSimpleClientset, but rather provide helpers with objects\ fixup! add namespaces * testutil/asserter: check if specGroups are empty and fail in that case * testutil/asserter: make Excluding copy-safe * test/ksm: share the asserter again I've added comments explaining how this works, which will hopefully improve readability.
paologallinaharbur
pushed a commit
that referenced
this pull request
Jan 17, 2022
* test: new integration testing backbone kubernetes-static main has been migrated to the new backbone as well Signed-off-by: Roberto Santalla <[email protected]> * test/integration: make Version object return mocks Signed-off-by: Roberto Santalla <[email protected]> * test/integration: implement the Asserter Asserter is a (hopefully) powerful tool to assert that all metrics defined in a SpecGroup are correctly captured. Signed-off-by: Roberto Santalla <[email protected]> * test/integration: implement helper for building integrations Signed-off-by: Roberto Santalla <[email protected]> * test/asserter: log missing metric namespace Signed-off-by: Roberto Santalla <[email protected]> * test/asserter: make asserter fully thread-safe Signed-off-by: Roberto Santalla <[email protected]> * test/ksm: optimize asserter calls on test parallelization Signed-off-by: Roberto Santalla <[email protected]> * fixup! test/asserter: typos Signed-off-by: Roberto Santalla <[email protected]> * testutil: make LatestVersion rely on the order of AllVersions * testutil: do not wrap fake.NewSimpleClientset, but rather provide helpers with objects\ fixup! add namespaces * testutil/asserter: check if specGroups are empty and fail in that case * testutil/asserter: make Excluding copy-safe * test/ksm: share the asserter again I've added comments explaining how this works, which will hopefully improve readability.
paologallinaharbur
pushed a commit
that referenced
this pull request
Jan 17, 2022
* test: new integration testing backbone kubernetes-static main has been migrated to the new backbone as well Signed-off-by: Roberto Santalla <[email protected]> * test/integration: make Version object return mocks Signed-off-by: Roberto Santalla <[email protected]> * test/integration: implement the Asserter Asserter is a (hopefully) powerful tool to assert that all metrics defined in a SpecGroup are correctly captured. Signed-off-by: Roberto Santalla <[email protected]> * test/integration: implement helper for building integrations Signed-off-by: Roberto Santalla <[email protected]> * test/asserter: log missing metric namespace Signed-off-by: Roberto Santalla <[email protected]> * test/asserter: make asserter fully thread-safe Signed-off-by: Roberto Santalla <[email protected]> * test/ksm: optimize asserter calls on test parallelization Signed-off-by: Roberto Santalla <[email protected]> * fixup! test/asserter: typos Signed-off-by: Roberto Santalla <[email protected]> * testutil: make LatestVersion rely on the order of AllVersions * testutil: do not wrap fake.NewSimpleClientset, but rather provide helpers with objects\ fixup! add namespaces * testutil/asserter: check if specGroups are empty and fail in that case * testutil/asserter: make Excluding copy-safe * test/ksm: share the asserter again I've added comments explaining how this works, which will hopefully improve readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the test data from the
cmd/kubernetes-staticfolder to aninternal/testutilone, and adds some goodies on top. This newtestutilpackage contains:httptest.Serverwhich exposes all the required metrics from services for a particular versionWith this, a
WIPtest for the newksm.Scraperhas been added as well.