New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/consumer offset no consumers #172

Merged

alvarocabanas merged 30 commits into master from feat/consumerOffsetNoConsumers

Jul 1, 2022

Member

paologallinaharbur commented May 25, 2022 •

edited by alvarocabanas

Loading

Add consumerGroup offsets and lag for consumer groups with inactive consumers

paologallinaharbur commented

View reviewed changes

Makefile Outdated Show resolved Hide resolved

paologallinaharbur commented

View reviewed changes

src/args/args.go Show resolved Hide resolved

paologallinaharbur commented

View reviewed changes

src/consumeroffset/collect.go Show resolved Hide resolved

paologallinaharbur commented

View reviewed changes

src/consumeroffset/kafka_offset_collect.go Outdated Show resolved Hide resolved

paologallinaharbur commented

View reviewed changes

src/consumeroffset/kafka_offset_collect.go Outdated Show resolved Hide resolved

paologallinaharbur commented

View reviewed changes

tests/integration/kafka_test.go Outdated Show resolved Hide resolved

alvarocabanas force-pushed the feat/consumerOffsetNoConsumers branch from 9eb35ef to 252744a Compare

June 21, 2022 15:47

alvarocabanas marked this pull request as ready for review

June 29, 2022 09:58

sigilioso requested a review from a team

June 29, 2022 13:39

alvarocabanas reviewed

View reviewed changes

src/consumeroffset/kafka_offset_collect.go Show resolved Hide resolved

sigilioso reviewed

View reviewed changes

Contributor

sigilioso left a comment

I think the changes have good shape, great job so far! I left some comments, basically typos and some suggestion to try to make it easier to follow.

src/args/args.go Outdated Show resolved Hide resolved

src/args/args.go Show resolved Hide resolved

src/consumeroffset/kafka_offset_collect.go Outdated Show resolved Hide resolved

src/consumeroffset/kafka_offset_collect.go Show resolved Hide resolved

src/consumeroffset/kafka_offset_collect.go Outdated Show resolved Hide resolved

src/consumeroffset/kafka_offset_collect_test.go Outdated Show resolved Hide resolved

src/consumeroffset/kafka_offset_collect_test.go Show resolved Hide resolved

sigilioso reviewed

View reviewed changes

Contributor

sigilioso left a comment

Thanks for addressing the comments! I think it is easier to follow now. I've left a couple of additional comments and questions.

src/consumeroffset/cgroup_metrics_aggregator.go Outdated Show resolved Hide resolved

src/consumeroffset/kafka_offset_collect.go Show resolved Hide resolved

src/consumeroffset/client_metrics_aggregator.go Show resolved Hide resolved

src/consumeroffset/kafka_offset_collect.go Show resolved Hide resolved

src/consumeroffset/kafka_offset_collect.go Show resolved Hide resolved

paologallinaharbur and others added 18 commits

July 1, 2022 09:49


          feat(kakfa): WIP

a1059b7


          feat(kakfa): WIP

dd606b3


          No_Offset in constant

9be910e


          Add new consumerOffset args

21f933d


          Create new topic Offset getter with cache

244083a


          Add inactive consumers to kafka offset collection

232a6a8


          Separate lag totals calculation in another file

8d8a218


          Create interface for topicOffsetGetter

e4f4a43


          Add topicLister with cache

29b0f24


          Make interface method public and goimports

f1e1141


          Add first kafka offset collect unit test

da7b5d0


          Add all cases to kafka offset collect unit test

8b3d81d


          Parallelize tests

0cda8e1


          Remove test Parallelization because of global args

7ad5735


          Fix linting problems

80fdee2


          remove test from linter

dc636dd


          Fix linting errors

6d40085


          Reformat calculate lag totals functions

310a25b

alvarocabanas and others added 11 commits

July 1, 2022 09:51


          gofmt the collect_test

a3292cf


          Fix docker-compose for integration tests

8c170cd


          Recover docker-compose down and exit on integration-test

5d05a1f


          Typo TopicExclusions

475e5b5


          Correct numEntities typo

f436791


          Update src/args/args.go

369f172

Co-authored-by: Christian Felipe Álvarez <[email protected]>


          Extract channel result feeding from collect function

0f32584


          Modify variable name


          Refactor aggregate kafka metrics

20b565a


          Fix client aggregator and add condition to test

9350b80


          Create interface for aggregators

1f792b3

alvarocabanas force-pushed the feat/consumerOffsetNoConsumers branch from 001a78f to 1f792b3 Compare

July 1, 2022 07:53


          Export ClientAggregations for linter

bdb257f

sigilioso approved these changes

View reviewed changes

Contributor

sigilioso left a comment

Great job! 👍

alvarocabanas merged commit 87c6c55 into master

alvarocabanas deleted the feat/consumerOffsetNoConsumers branch

July 1, 2022 10:06

alvarocabanas changed the title ~~Feat/consumer offset no consumers~~ Feat/consumer offset no consumers - issue https://github.com/newrelic/nri-kafka/issues/160

alvarocabanas changed the title ~~Feat/consumer offset no consumers - issue https://github.com/newrelic/nri-kafka/issues/160~~ Feat/consumer offset no consumers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet