Added auto detection for kubelet client config #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfig cmd line arg
brushknight
reviewed
Nov 5, 2020
| ) | ||
|
|
||
| var _ = flag.String(namespaces, "", "(optional, default '') Comma separated list of namespaces to discover pods on") | ||
| var _ = flag.Bool(insecure, false, `(optional, default false, deprecated) Use insecure (non-ssl) connection. | ||
| For backwards compatibility this flag takes precedence over 'tls')`) | ||
| var _ = flag.Bool(autoConfig, false, "(optional, default false) fetch node info for configuration") | ||
| var _ = flag.Int(timeout, 5000, "(optional, default 5000) timeout in ms") |
There was a problem hiding this comment.
do we need to mention this new flag in PR description + release notes?
brushknight
reviewed
Nov 5, 2020
internal/http/client.go
Outdated
| } | ||
|
|
||
| buff, _ := ioutil.ReadAll(resp.Body) | ||
| _ = resp.Body.Close() |
There was a problem hiding this comment.
why do we need this blank variable?
There was a problem hiding this comment.
It makes linters happy when you assign errors to a blank variable rather than just ignoring them.
There was a problem hiding this comment.
I'm more concerned we don't check the error from ioutil.ReadAll or at least make it part of the return on line 90.
carlosroman
reviewed
Nov 9, 2020
carlosroman
reviewed
Nov 9, 2020
carlosroman
reviewed
Nov 13, 2020
| return found | ||
| } | ||
|
|
||
| // IsAutoConfig returns true if no config parameter was provided as cmd line arg. |
carlosroman
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add the capability to auto-detect the kubelet endpoint configuration by fetching the node information.
If this mechanism will be used only if no configuration is specified via cmd line args.
If this mechanism fails, the old behavior is use.
In addition to this, a new flag is added to be able to overwrite the hostname
--host (default localhost). If not specified the previous behavior is maintained.